Re: be registered as an Octave Forge developer

[Mike Miller]

On Thu, Mar 20, 2014 at 10:41:01 +0100, Bastian Ebeling wrote:
> Hi there,
> 
> this is me Bastian (barry1 on sf.net).
> 
> I'd like to aplly a change to
> octave/packages/signal-1.1.3/czt.m
> 
> given as this diff
> 
> --- /usr/share/octave/packages/signal-1.1.3/czt.m 2012-05-17
> 22:38:46.000000000 +0200
> +++ czt.m 2014-03-20 08:16:59.257637103 +0100
> @@ -65,6 +65,8 @@
>    nfft = 2^nextpow2(n+m-1); # fft pad
>    W2 = w.^(([-(n-1):max(m-1,n-1)]'.^2)/2); # chirp
> 
> +  y=zeros(row,col); # y should not grow in loop
> +
>    for idx = 1:col
>      fg = fft(x(:,idx).*(a.^-(N-n)).*W2(N), nfft);
>      fw = fft(1./W2(NM), nfft);
> 
> 
> You can see, the only change is a preallocation command for the output y
> the prepend growing in the loop.

This change looks reasonable, aside from the coding style. Thanks for
offering to help.

Please try to follow the Octave guidelines for this and future
contributions:
  
https://www.gnu.org/software/octave/doc/interpreter/Contributing-Guidelines.html

I am not the right person to answer about adding you to Octave Forge,
but now that the signal package is using a DVCS, you have many more
options.

You can "hg export" your changeset as a patch and post it to the Octave
patch tracker:
  https://savannah.gnu.org/patch/?func=additem&group=octave

You can push your changes to another hg repository that you own and host
publically, and ask (on the patch tracker) for the change to be pulled.

You can "fork" my copy of the signal repository on bitbucket and issue a
pull request using bitbucket's tools:
  https://bitbucket.org/mtmiller/octave-signal

FYI, I push changes more frequently to the following repository, simply
because it's mine and it's faster for me than sourceforge, so it may be
ahead of what's on sourceforge at times:
  https://hg.mtmxr.com/octave-signal/

Thanks again, I'm looking forward to your future contributions.

-- 
mike

signature.asc
Description: Digital signature