Re: Savannah Status for patches which have been reviewed

[John W. Eaton]

On 01/17/2017 11:41 PM, Rik wrote:

> Twice in the last week I've run in to the situation on the bug tracker
> where a patch has been submitted, and an Octave regular has reviewed it,
> and it now needs only a quick glance by a second set of eyes before being
> committed.  What is the appropriate "Status" field to use for this
> situation?  Is it "Ready for Test"?  Or should a new status entry "Patch
> Reviewed" be added?

A "Patch Reviewed" status might help, at least for sorting purposes, so 
you might as well add it.

It would also be useful to tag a list of people who might be the best 
qualified to review the patch.  But I don't see a way to do that other than

  * adding them to the notification list, but after the initial notice, 
I think it is easily forgotten and I'm not sure if there is a way to 
search for all the bugs where you appear on the notification list

  * assigning the bug to an individual, but that is only for a single 
person, as far as I can tell, so it doesn't really work for requesting 
that multiple people review a patch

> The problem is that there are bugs on the tracker for which the solution is
> already available (patch submitted and reviewed), but which won't get
> committed until some time close to the 4.4.0 release when the Maintainers
> make a concerted effort to review and close out bugs.  If there were a
> simple way to sort for bugs which are at this final stage they might get
> committed sooner.

I definitely agree that we should try review/accept/reject patches as 
soon as possible and not put them off until there is a big rush just 
prior to a release.

jwe