|
From: | Rik |
Subject: | [Octave-patch-tracker] [patch #8157] regexp.cc: prevent cast of negative floating point value to uint32_t. |
Date: | Wed, 07 Aug 2013 16:15:21 +0000 |
User-agent: | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 |
Follow-up Comment #1, patch #8157 (project octave): Given that addition is associative and commutative, can we simply do away with the subtraction altogether? (p->end() -1) + 1 => p_end() + (-1 + 1) => p_end() + (0) => p_end() Also, could you rebase your patch onto the development branch? The file liboctave/util/regexp.cc has been renamed to liboctave/util/lo-regexp.cc so the changest doesn't import cleanly. _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/patch/?8157> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |