[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8119] Allow variable tolerance and improv
From: |
Dan Sebald |
Subject: |
[Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script |
Date: |
Fri, 16 Aug 2013 03:41:41 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 SeaMonkey/2.15 |
Follow-up Comment #25, patch #8119 (project octave):
Yes, probably so. I didn't realize there would be much change when starting
though. Nonetheless, it's nice to see it now near what the FIXME had in
mind.
I thought about ruling out multiple errors for the same index, but felt it OK
as is. I don't mind it either way really.
That's right, there's another "error" at the top of the function. "##
Perhaps, say which elements failed?" -- yes it could probably be more
explicit, but what to say? Also, rather than decrement the depth level and
error at the place of the conditional, another approach would be to just
define the error message and let it fall through to the end at which point the
error will occur because errmsg is not empty, i.e.,
if (nargin == 1)
## Perhaps, say which elements failed?
errmsg = sprintf ("assert %s failed", in);
else
errmsg = (varargin{:});
end_if
Thanks for all the work on this.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8119>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, (continued)
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Rik, 2013/08/07
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Dan Sebald, 2013/08/07
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Rik, 2013/08/08
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Dan Sebald, 2013/08/11
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Dan Sebald, 2013/08/12
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Dan Sebald, 2013/08/12
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Dan Sebald, 2013/08/12
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Rik, 2013/08/14
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Dan Sebald, 2013/08/14
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script, Rik, 2013/08/15
- [Octave-patch-tracker] [patch #8119] Allow variable tolerance and improve error messages for assert.m script,
Dan Sebald <=