[Octave-patch-tracker] [patch #8215] thiran function (for controls package)

[Thomas Vasileiou]

Follow-up Comment #4, patch #8215 (project octave):

Hi Spencer,

Thanks very much for your patch. I have updated the implementation so as to
calculate the thiran coefficients as you proposed.

I have a comment, for future submissions.
A patch should be properly tested before submission. If you run the proposed
example in the header of your file:
'thiran(4.4, 0.5)'
I get the following warning:
'warning: operator +: automatic broadcasting operation applied'
since you add a column and a row vector.
Patches should not return warnings ...

best
Thomas

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8215>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/