[Octave-patch-tracker] [patch #8517] Legendre-Papoulis filter design (for signal package)

[Mike Miller]

Update of patch #8517 (project octave):

                  Status:                    None => In Progress            
             Assigned to:                    None => mtmiller               

    _______________________________________________________

Follow-up Comment #1:

Thanks for your contribution to Octave! This function can definitely be added
to the signal package. Would you mind looking at some coding style fixups and
adding unit tests?

It would be best for all new functions added to the signal package to adhere
to GNU Octave coding style conventions. Here are some suggestions based on a
quick review of your submission (based on a suggestions made for other recent
submissions):

* Use 2 spaces for indentation
* Remove trailing spaces from all lines
* Use endif instead of end
* Use space before opening parenthesis on function calls, if, switch, etc, no
space when indexing
* If conditions: use parentheses around even trivial conditions
* For loops: use parentheses on loop initializers
* Keep parentheses on function calls with no arguments (e.g. print_usage ())
* Use Texinfo format for public function documentation
* Make sure to indicate the function name in error messages

Some simple particulars about this function:

* Prefer lower case variable and inner function names, unless you want to
differentiate matrices from scalars using uppercase local variable names

Can you write some tests for legendap as well?

Would you agree to rename these functions to "legendreap" and "legendref"? I
think it would be clearer to distance these functions from the plotting
function "legend".

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8517>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/