[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8695] A patch for function randsample in
|
From: |
Carnë Draug |
|
Subject: |
[Octave-patch-tracker] [patch #8695] A patch for function randsample in statistics pkg |
|
Date: |
Sat, 04 Jul 2015 00:10:13 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.7.0 |
Follow-up Comment #2, patch #8695 (project octave):
Some comments
* your patch needs to follow octave coding guidelines. This means indenting
the function block, explicit end (use endif, endfunction, etc), space after
function names, use of # for comments, 2 space indentation.
* why commented code? If you don't need it anymore, just remove it.
* why did you remove the %! test blocks? These are formatted in a special way
to be identified as tests by octave. Run "test randsample"
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8695>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/