[Octave-patch-tracker] [patch #8693] Reimplement operator * (const SparseMatrix& m, const SparseMatrix& a) to use SuiteSparse

[Mike Miller]

Update of patch #8693 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #2:

I've reviewed this patch for coding style, commit message guidelines, and
verified that it applies cleanly, compiles, and make check runs with no new
failures.

I have *not* reviewed the design choices or the basic functionality or
performance changes that this patch addresses.

Revised patch attached with the following changes:

 * author's name in the commit header
 * commit message edited to be consistent with our practice
 * whitespace cleanup
 * TODO changed to FIXME
 * the last line of the function changed to compile for me (and reason for the
const_cast unnecessary I think)

There's not much more reviewing I can bring to this patch, so not assigning to
myself. Someone with more familiarity with the design of the sparse array
classes and with the SuiteSparse library will have to validate the rest.

(file #35730)
    _______________________________________________________

Additional Item Attachment:

File name: revised-8693.patch             Size:9 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8693>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/