[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8856] add function reducevolume
From: |
Philip Nienhuis |
Subject: |
[Octave-patch-tracker] [patch #8856] add function reducevolume |
Date: |
Sat, 16 Jan 2016 22:57:02 +0000 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 |
Follow-up Comment #3, patch #8856 (project octave):
Marvellous job! Thanks very much
As to coding style, I've only managed to spot and change the "~" operator in
lines 137, 144 and 151 to "! ".
Your family name didn't come through - I hope you don't mind I spelled it as
Muetzel in the copyright line?
As your name is in the function, I suppose you do not mind to be mentioned in
the list of contributors?
I tried the example on the Mathworks site; that works well as far as other
missing functions go (smooth3, isocaps, camlight, lighting); the resulting
picture resembles the shape on the TMW page quite well.
That's as far as I can test the validity and proper operation of the
function.
I'll cc an other core devs about his opinion on where to put it (I'm merely a
contributor with push credentials).
@Rik:
If you agree, I can make a cs & push it to default in the next week or week
after. Where should it be put? plot/util? image? geometry? statistics?
(file #36058)
_______________________________________________________
Additional Item Attachment:
File name: reducevolume.m Size:10 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8856>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/