[Octave-patch-tracker] [patch #8783] C++ implementation of textscan

[John W. Eaton]

Follow-up Comment #92, patch #8783 (project octave):

Lachlan and Philip, thanks for all the work on this function.

I applied the latest changeset to the Octave sources and pushed it here:

http://hg.savannah.gnu.org/hgweb/octave/rev/b7d1e93c0702

Running the tests caused a strange crash for me (double free when calling the
destructor for textscan even though there is no explicitly defined destructor
for that class) which I think I tracked down to an out of bounds assignment to
delim_table.  I avoided that in the following changeset, though I'm not sure
this is the correct fix (why -2):

http://hg.savannah.gnu.org/hgweb/octave/rev/a4c411681e25

While trying to understand why the crash was happening, I ran the textscan
tests with valgrind.  I'm attaching a log of what I see.  Search for "Invalid
read size of 1" and you'll see that there seem to be some places where arrays
or strings are accessed out of bounds.  I'm not sure what the best fix is, but
these need to be cleaned up.

(file #36677)
    _______________________________________________________

Additional Item Attachment:

File name: textscan-valgrind-log.txt      Size:51 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8783>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/