[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8951] Calculate vertexnormals for patch o
From: |
Pantxo Diribarne |
Subject: |
[Octave-patch-tracker] [patch #8951] Calculate vertexnormals for patch objects |
Date: |
Mon, 11 Apr 2016 17:23:27 +0000 |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #2, patch #8951 (project octave):
Hi Markus,
I didn't take enough time to review this patch but I hope to do so, step by
step with the few spare hours I have. Here is my first comment: Matlab has two
distinct properties for patch normals, vertexnormals and facenormals (and
their corresponding *mode). Can you clarify the role of those two and why you
chose to implement vertexnormals only. We can add the support for one after
the other but at least we should change normalmode to vertexnormalmode.
Also ML only computes those properties when a light object is present, did you
notice a significant performance penalty over large number of patches?
[1] http://fr.mathworks.com/help/matlab/ref/patch-properties.html
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8951>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #8951] Calculate vertexnormals for patch objects,
Pantxo Diribarne <=