[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9032] New function binotest for statistic
|
From: |
Nir Krakauer |
|
Subject: |
[Octave-patch-tracker] [patch #9032] New function binotest for statistics package |
|
Date: |
Fri, 24 Jun 2016 15:49:35 +0000 (UTC) |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/601.4.4 (KHTML, like Gecko) Version/9.0.3 Safari/601.4.4 |
Follow-up Comment #1, patch #9032 (project octave):
Hi Andreas,
This is a nice contribution, but I see a few problems:
1) Computed two-tailed p values can be > 1, for example
[h, p, ci] = binotest (7,14,0.5)
with p = 1.2095
2) There is an error when pos == 0 or pos == n, for example
[h, p, ci] = binotest (0,14,0.5)
[h, p, ci] = binotest (14,14,0.5)
3) Also, "There are two methods to define the two tailed p-value" (
https://en.wikipedia.org/wiki/Binomial_test ) when p0 != 0.5. So we should
either allow the user to choose which method to use, or at least document
which is the method available.
Can you check on these?
Nir
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?9032>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/