[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #8837] normest1
From: |
Carnë Draug |
Subject: |
[Octave-patch-tracker] [patch #8837] normest1 |
Date: |
Wed, 13 Jul 2016 17:22:55 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #11, patch #8837 (project octave):
Why not the second point? On line 96 you have
[est, idx] = max (sum (abs (A)));
but that "est" value is never used. So why not [~, idx] = max (sum (abs (A)))
?
There's a few other style changes but I can make them myself after you push
(but can you unindent the "endfunction"?)
Also, I just found that while this function seems to be on Matlab R2010b, I's
no longer on their online documentation. I don't see mention on the release
notes about its removal. Is this an undocumented function or have they
replaced with something else?
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8837>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #8837] normest1, Lachlan Andrew, 2016/07/06
- [Octave-patch-tracker] [patch #8837] normest1, Marco Caliari, 2016/07/06
- [Octave-patch-tracker] [patch #8837] normest1, Lachlan Andrew, 2016/07/06
- [Octave-patch-tracker] [patch #8837] normest1, Lachlan Andrew, 2016/07/06
- [Octave-patch-tracker] [patch #8837] normest1, Carnë Draug, 2016/07/08
- [Octave-patch-tracker] [patch #8837] normest1, Marco Caliari, 2016/07/12
- [Octave-patch-tracker] [patch #8837] normest1,
Carnë Draug <=
- [Octave-patch-tracker] [patch #8837] normest1, Nir Krakauer, 2016/07/14
- [Octave-patch-tracker] [patch #8837] normest1, Lachlan Andrew, 2016/07/14
- [Octave-patch-tracker] [patch #8837] normest1, Marco Caliari, 2016/07/15
- [Octave-patch-tracker] [patch #8837] normest1, Carnë Draug, 2016/07/15
- [Octave-patch-tracker] [patch #8837] normest1, Marco Caliari, 2016/07/15
- [Octave-patch-tracker] [patch #8837] normest1, Marco Caliari, 2016/07/25
- [Octave-patch-tracker] [patch #8837] normest1, Carnë Draug, 2016/07/25
- [Octave-patch-tracker] [patch #8837] normest1, Carnë Draug, 2016/07/26
- [Octave-patch-tracker] [patch #8837] normest1, Carnë Draug, 2016/07/26
- [Octave-patch-tracker] [patch #8837] normest1, Carnë Draug, 2016/07/30