octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9281] Image package: imsharpen


From: Avinoam Kalma
Subject: [Octave-patch-tracker] [patch #9281] Image package: imsharpen
Date: Sat, 11 Mar 2017 15:57:32 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Follow-up Comment #3, patch #9281 (project octave):

Attached a better version, fixed according to comment#1 (Thanks Hartmut).

* I changed the tolerance of the failing test to 1, so it will not fail, but
still, there is 1 gray level difference between my results and Matlab
results.

* texinfo was fixed.
  
* Line 54: copy/paste error was fixed.

* I removed the clipping. I did not find differences after the removal.

* More example were added for uint8 input.

* Wrong indentation was fixed.

* I added more tests for few values of "Amount". I hope it checks the Gaussian
size.


And more more problem: I have tried to change


 Lab = rgb2lab (I);


to


 Lab = rgb2lab (double(I));

 
It fixed one test, but in made other test to fail. Any idea about this?

Please review the attached new version. Thanks.



(file #39973)
    _______________________________________________________

Additional Item Attachment:

File name: imsharpen.m                    Size:8 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9281>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]