octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9282] add minres for sparse linear system


From: Marco Caliari
Subject: [Octave-patch-tracker] [patch #9282] add minres for sparse linear systems
Date: Wed, 15 Mar 2017 03:59:23 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Follow-up Comment #11, patch #9282 (project octave):

You can remove the try..catch inside the iteration: if the preconditioner is
singular in the ## Initiation stage, the code will return. Cristiano used
ishermitian only in some tests, I think you can remove from the code.

I think you should change the stagnation criterion. It is almost impossible
that two consecutive iterations coincide (with ==). You should use something
like norm(resvec(k+1)-resvec(k)) <= eps * norm(resvec(k+1)).

I see you use a left preconditioner, while Matlab a split one.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9282>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]