[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9302] Mapping package. Included some func
From: |
Philip Nienhuis |
Subject: |
[Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others. |
Date: |
Wed, 29 Mar 2017 14:54:35 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 SeaMonkey/2.46 |
Follow-up Comment #5, patch #9302 (project octave):
Mithil,
Thanks for your contributions.
I took a brief look and noted following:
deg2sm.m & deg2nm.m & rad2nm.m & rad2sm.m:
* (C) 2013 Carnë Draug ?? (did you copy verbatim from another function? I
suppose you as author have the copyright)
* These functions need tests, also input validation tests. E.g.,
%!error <validatestring: 'feet' does not match any of> earthRadius ("feet")
(and why no "feet" or "nm"/"nauticalmile" or other measures as acceptable
input? Octave could do better than Matlab!
* The persistent statement had better be in the first lines of the function
body
* Could you please also implement alternative radii of celestial bodies? E.g.,
sm2deg has them.
earthradius.m:
* (C) 2017 Carnë Draug ?? see above
* needs input validation tests (see example above)
Other than that you did a good job of adhering to coding style standards.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?9302>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Mithil, 2017/03/25
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Philip Nienhuis, 2017/03/26
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Mithil, 2017/03/27
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Mithil, 2017/03/27
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Mithil, 2017/03/27
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Philip Nienhuis, 2017/03/27
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Philip Nienhuis, 2017/03/27
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others., Philip Nienhuis, 2017/03/27
- [Octave-patch-tracker] [patch #9302] Mapping package. Included some functions and improved few others.,
Philip Nienhuis <=