[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9354] image package: new function wiener2
From: |
Avinoam Kalma |
Subject: |
[Octave-patch-tracker] [patch #9354] image package: new function wiener2.m |
Date: |
Wed, 24 May 2017 14:10:23 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 |
Follow-up Comment #2, patch #9354 (project octave):
Looks very good, passes all the tests, and even has a nice demo.
I can only remark on a few typos:
* Missing space in line 119.
* I would change "formulas" to "equations" in line 46.
* lines 43-46 should be part of the user documentation.
* Minor incompatibility in a corner case: wiener2 (I, [-5 0]) returns zeros in
Matlab, and does not issue an error. I do not know if you should fix this,
because it is really an error.
I recommend to include wiener2 in image package.
Thanks :-)
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?9354>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/23
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/24
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m,
Avinoam Kalma <=
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/25
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Avinoam Kalma, 2017/05/25
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/25
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Avinoam Kalma, 2017/05/25
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Carnë Draug, 2017/05/26
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/27
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/30
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Carnë Draug, 2017/05/30
- [Octave-patch-tracker] [patch #9354] image package: new function wiener2.m, Hartmut, 2017/05/31