[Octave-patch-tracker] [patch #9354] image package: new function wiener2.m

[Carnë Draug]

Follow-up Comment #14, patch #9354 (project octave):

Thank you for the tests and comments.  I added your new tests, fixed
the docs, adjusted input check, and made imcast support class logical.

https://bitbucket.org/carandraug/octave-image/commits/8a7e8063889672a98fed99d15b73d46a1c8a245c

Could you find write some tests for what happens with even sized nhood
such as [2 3], [4 3], and [4 4]?

> Your new test fails on my linux machine. The absolute errors are on
> the order of 1e-4 (except for the 5,5,5 position in one result
> image, this is off by 0.0018.) Maybe you should add a looser
> tolerance to this new test, or is there a typo somewhere?

There is no typo.  This works on my machine.  I have seen some tests
failing because of machine precision but that was rarely for more than
1-2 orders of magnitude.  You are suggesting changing from eps to 1e-4
which is a very large difference.  I'd be curious to find out why the
big difference.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/