[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPol
From: |
Juan Pablo Carbajal |
Subject: |
[Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns |
Date: |
Sat, 25 Nov 2017 23:37:49 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.75 Safari/537.36 |
Follow-up Comment #6, patch #9494 (project octave):
Hi,
Yes definitely is worth merging.
I tihnk you missed all the mails I sent during the last GSoC, you wouldn't be
so surprised now :D.
The criteria was: keep matgeom naming convention to avoid multiple changes
(matGeom is adding some of these functions). Put geometric functions in the
geometry package and not in mapping.
ispolycw:
The geometry function isPolygonCW[1] has both methods, either geometry or
clipper. Seems the studnet didn't finish the job in the funcAliases folder,
they shouldn't implement functionality, just wrap. The idea is that it has a
default argument (either geometry or clipper) and calls the geometry
function.
If you have the time, please go ahead with the merging.
[1]:
https://sourceforge.net/p/octave/geometry/ci/2be7484d72c9cf0c021c16a5a9852e23678792dd/tree/inst/polygons2d/isPolygonCCW.m
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?9494>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Philip Nienhuis, 2017/11/19
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Philip Nienhuis, 2017/11/19
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Juan Pablo Carbajal, 2017/11/19
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Philip Nienhuis, 2017/11/20
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Juan Pablo Carbajal, 2017/11/20
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Philip Nienhuis, 2017/11/21
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Philip Nienhuis, 2017/11/24
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns,
Juan Pablo Carbajal <=
- [Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns, Philip Nienhuis, 2017/11/26