[Octave-patch-tracker] [patch #9448] image package: new function imfindcircles.m

[Carnë Draug]

Follow-up Comment #5, patch #9448 (project octave):

> (Sorry, I didn't manage to leave comments directly in your bitbucket repo.)

Bitbucket only allows comments on commits. You can't comment on source files
alone.

> * There is a typo somewhere: "directions late ron."

Found it and fixed now.

> * I think the function imhmax(f, h) can be fully deleted in the code of
imfindcircles.
> * The function imregionalmax(img) can also be deleted inside the code of
imfindcircles.

I will remove them when I rebase the commits. At the moment, they're branching
from a commit where those functions don't exist.

> * The last section (visualize the found circles in the image) in the !demo
code can be re-written much nicer now, because imviscircles is implemented.
(It should turn into roughly a one-liner.)

Similarly, viscircles is not available on this head. I will adjust when I
rebase.  I am also thinking of also simplifying it by using phantom() to
generate the test data. Like so:


model = [ 1.0   0.2   0.2   0.2   0.5   0
          1.0   0.3   0.3  -0.1  -0.2   0
         -0.5   0.7   0.7  -0.5   0.5   0];
im = phantom (model);
imshow (im);
[centers, radii] = imfindcircles (im, [20 50]);
viscircles (centers, radii)


> * Do the tests all still pass?

Yes.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9448>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/