[Octave-patch-tracker] [patch #9084] uitable implementation

[Hg200]

Follow-up Comment #42, patch #9084 (project octave):

Hi,

I looked at the file #45472, file #45473 and file #45474

1.) The patch file #44579 used has a problem which can be made visible if a
diff between file #44579 and the patch file #44572 is made. I think Philip
Nienhuis patch (file #44579) is correct. To solve the problem you only need to
change one line. Go to


/doc/interpreter/module.mk


and add


$(GRAPHICS_PROPS_SRC)


to the end of the line


%reldir%/plot-uitableproperties.texi: doc/interpreter/genpropdoc.m


Then you are done.

2.) I'am happy with "str2double" DEFUN in utils.cc and the implementation
"octave_str2double" in lo-utils.cc. I just got a bit confused because the
str2double helper functions (extract_num, is_imag_unit) have now been merged
into lo-utils.cc as well. To my taste this was a little bit "nicer" before but
it is not a big deal anyway.

3.) I agree to keep track of the open bugs in a separate bug report after the
implementation has been pushed.

Thank you and have a nice day

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9084>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/