|
From: | Philip Nienhuis |
Subject: | [Octave-patch-tracker] [patch #9743] [octave forge] (statistics) silhouette function |
Date: | Sun, 13 Jan 2019 14:48:01 -0500 (EST) |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 |
Follow-up Comment #1, patch #9743 (project octave): Thank you for this contribution. Very good Octave coding style. A quick look shows that it needs some work: * It needs tests * The nested functions had better be moved outside the main function Then still some nitpicking (apologies!) as regards Octave coding style: - endfunction rather than end - start comment lines with ## rather than % - texinfo header rather than plain text - space between function names and their arguments For examples take about any .m-file function from the statistics package. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/patch/?9743> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |