[Octave-patch-tracker] [patch #9806] Build failures on macOS via Homebrew due to 1.6 argument to -source and -target

[anonymous]

URL:
  <https://savannah.gnu.org/patch/?9806>

                 Summary: Build failures on macOS via Homebrew due to 1.6
argument to -source and -target
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Tue 14 May 2019 04:24:21 PM UTC
                Category: Core : other
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Building 5.1.0 from source on macOS under 1.14.4 (Mojave) via mac Homebrew
(<https://brew.sh>) results in the following build failure:

Build command:

brew install --build-from-source --verbose octave



build-aux/install-sh -c -d scripts/java/org/octave && \
        ( cd ./scripts/java; \
         
"/Library/Java/JavaVirtualMachines/openjdk-12.0.1.jdk/Contents/Home/bin/javac"
-source 1.6 -target 1.6 -Xlint:-options \
                     -d
/private/tmp/octave-20190514-42663-hrgy0r/octave-5.1.0/scripts/java \
                     org/octave/ClassHelper.java )
Updating 'libgui/languages/uk_UA.qm'...
    Generated 48 translation(s) (0 finished and 48 unfinished)
    Ignored 863 untranslated source text(s)
build-aux/install-sh -c -d scripts/java/org/octave && \
        ( cd ./scripts/java; \
         
"/Library/Java/JavaVirtualMachines/openjdk-12.0.1.jdk/Contents/Home/bin/javac"
-source 1.6 -target 1.6 -Xlint:-options \
                     -d
/private/tmp/octave-20190514-42663-hrgy0r/octave-5.1.0/scripts/java \
                     org/octave/Matrix.java )
Updating 'libgui/languages/zh_CN.qm'...
    Generated 856 translation(s) (842 finished and 14 unfinished)
    Ignored 55 untranslated source text(s)
build-aux/install-sh -c -d scripts/java/org/octave && \
        ( cd ./scripts/java; \
         
"/Library/Java/JavaVirtualMachines/openjdk-12.0.1.jdk/Contents/Home/bin/javac"
-source 1.6 -target 1.6 -Xlint:-options \
                     -d
/private/tmp/octave-20190514-42663-hrgy0r/octave-5.1.0/scripts/java \
                     org/octave/OctClassLoader.java )
Picked up _JAVA_OPTIONS: 
-Duser.home=/Users/ibeekman/Library/Caches/Homebrew/java_cache
Picked up _JAVA_OPTIONS: 
-Duser.home=/Users/ibeekman/Library/Caches/Homebrew/java_cache
Picked up _JAVA_OPTIONS: 
-Duser.home=/Users/ibeekman/Library/Caches/Homebrew/java_cache
error: Source option 6 is no longer supported. Use 7 or later.
error: Target option 6 is no longer supported. Use 7 or later.
error: Source option 6 is no longer supported. Use 7 or later.
error: Target option 6 is no longer supported. Use 7 or later.
error: Source option 6 is no longer supported. Use 7 or later.
error: Target option 6 is no longer supported. Use 7 or later.


More details are available at
https://github.com/Homebrew/homebrew-core/issues/39848

I'm not sure whether or not you want or need to add some system introspection
for java to determine how to set the -source and -target flags, but the patch,
attached here and also at
https://github.com/Homebrew/formula-patches/commit/a8124b73c5216cc81d63627a4b41203ab1d91a4d
fixes the issue for me.

Please let me know if you require any additional information.

Thanks!



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 14 May 2019 04:24:23 PM UTC  Name: 5.1.0-java-version.patch  Size:
1KiB   By: None
patch for octave java build problem on macOS 10.14.4
<http://savannah.gnu.org/patch/download.php?file_id=46907>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9806>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/