[Octave-patch-tracker] [patch #8377] [octave forge] (mapping) 3D Coordinate system conversion functions for Geodesy

[Philip Nienhuis]

Follow-up Comment #25, patch #8377 (project octave):

Hi Anonymous,

While working on your aer* contributions I hit the following issues:

aer2ecef, aer2geodetic:
You forgot to add "!" after the "%" in the first tests, so they didn't work at
all.
After adding the exclamation marks the tests FAIL with large tolerances:

>> test aer2ecef
***** test
 [x2, y2, z2] = aer2ecef (33, 70, 1e3, 42, -82, 200);
 assert ([x2, y2, z2], [660.930e3, -4701.424e3, 4246.579e3], 10e-6)
 [x3, y3, z3] = aer2ecef ( 0.575958653158129, 1.22173047639603, 1e3, ...
                0.733038285837618, -1.43116998663535, 200, "", "rad");
 assert ([x3, y3, z3], [660.93019e3, -4701.42422e3, 4246.5796e3],10e-3)
!!!!! test failed
ASSERT errors for:  assert ([x2, y2, z2],[660.930e3, -4701.424e3,
4246.579e3],10e-6)

  Location  |  Observed  |  Expected  |  Reason
    (1)      660572.32156    660930      Abs err 357.68 exceeds tol 1e-05 by
4e+02
    (2)      -4700247.9148   -4701424     Abs err 1176.1 exceeds tol 1e-05 by
1e+03
    (3)      4245031.738    4246579      Abs err 1547.3 exceeds tol 1e-05 by
2e+03

>> test aer2geodetic
***** test
 [lat2, lon2, alt2] = aer2geodetic (33, 70, 1e3, 42, -82, 200);
 assert ([lat2, lon2, alt2], [42.0026; -81.9978; 1.1397e3], 10e-6)
 [lat2, lon2, alt2] = aer2geodetic ( 0.575958653158129, 1.22173047639603, 1e3,
0.733038285837618,
-1.43116998663535, 200, "", "rad");
 assert ([lat2, lon2, alt2], [42.0026; -81.9978; 1.1397e3], 10e-6)
!!!!! test failed
ASSERT errors for:  assert ([lat2, lon2, alt2],[42.0026; -81.9978;
1.1397e3],10e-6)

  Location  |  Observed  |  Expected  |  Reason
     .          O(1x3)       E(3x1)      Dimensions don't match


... and enu2uvw.m has no tests checking the calculation itself, just tests for
error checking.

All files:
Various of style issues:
* No parentheses around if clauses
* texinfo incomplete or too terse (but texinfo is somewhat hard so 'll grant
you those)
* incomplete input validation



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?8377>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/