[Octave-patch-tracker] [patch #9989] [statistics] improve the compatibility of 'linkage'

[Philip Nienhuis]

Update of patch #9989 (project octave):

                  Status:               Need Info => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #5:

Thanks, I didn't first note that you uploaded a changeset rather than a "diff
-u" as the extension suggested; all your details are inside. Fine.

While in current Octave-6.1.0 your patch doesn't influence the BIST tests, in
dev Octave-7.0.0 it does:

>> test linkage
***** assert (cond (linkage (pdist (x))),              34.119045,t);
!!!!! test failed
: function called with too many inputs
shared variables   scalar structure containing the fields:
    x =
       0   1   4
       3   2   3
       1   2   2
       3   3   0
       0   4   4
       4   4   3
       1   1   4
       2   1   0
       4   2   0
       3   2   0
       0   2   1
       1   3   1
    t = 1.0000e-06
>>


In Octave-6.1.0 there's also a wrangled warning at L.177:

>> test linkage.m
warning: clustering
warning: called from
    linkage at line 177 column 5
    __test__ at line 3 column 2
    test at line 677 column 11

warning: clustering
warning: called from
    linkage at line 177 column 5
    __test__ at line 3 column 2
    test at line 677 column 11

PASSES 12 out of 12 tests


All in all it looks like linkage.m needs a bit more attention than just your
patch.

Anyway I pushed your patch here:
http://hg.code.sf.net/p/octave/statistics/rev/48209fa818c1

Then, in your patch:
* why is arg#4 called 'savememmory' rather than 'savememory'? Name and content
of a variable don't bite each other if they're equal
* the if clause has a typo": 'if (nargin == 5) ...' rather than 'if (nargin ==
4) ...'
* Please use '! <logical expression>' rather than  '~ <logical expression>'

I fixed those and pushed that here:
http://hg.code.sf.net/p/octave/statistics/rev/74d9b0baa81a

Again, thanks for your contribution.
Closing report.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9989>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/