octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10104] [octave forge] (statistics) Add ne


From: Nicholas Jankowski
Subject: [Octave-patch-tracker] [patch #10104] [octave forge] (statistics) Add new function pca
Date: Mon, 30 Aug 2021 15:11:30 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36

Update of patch #10104 (project octave):

                  Status:                    None => In Progress            

    _______________________________________________________

Follow-up Comment #1:

perhaps worth adding to the help text something like
"Matlab compatibility note:  the method 'als' and associated options 'Coeff0',
'Score0', and 'Options' are not yet implemented"

it also looks like while an error is provided for the als method is present,
you could add error messages for those other options as well. e.g., "Parameter
%s is only valid with the 'ALS' method which is not yet implemented"

coding style things:
also looks like there's a .- at 302 that doesn't need to be there (all - are
elementwise, so .- is redundant), and there was maintainer discussion about
deprecating .- and .+ notation, so probably should remove.

some of your lines have end-of-line whitespace that should be removed. (mostly
blank lines).  

in this package for a new fn add it seems to be sufficient to mention the
bug/patch number at the end of the commit message

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10104>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]