[Octave-patch-tracker] [patch #10147] interpreter: Avoid string construction

[John W. Eaton]

Follow-up Comment #4, patch #10147 (project octave):

The first change seems OK, at least in functions that are called many many
times, but I'm not interested in changing all Octave code to use static const
std::string objects for every string literal.  The context matters.  For
example, there is no need for it in something like


if (some_error_condition)
  error ("...");


I don't think the other two changes are needed.  I'd rather avoid adding
things like "m_empty_string" member variables or const reference for ordinary
local variables.  Shouldn't std::move be used in those instances anyway, or
does something prevent that from happening?


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10147>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/