[Octave-patch-tracker] [patch #10344] Experimental stack VM for GNU Octave

[Markus Mützel]

Follow-up Comment #1, patch #10344 (project octave):

Thank you for that patch.

I tried to build on Windows on top of a current head of the default branch (hg
id 28ef2991fb5a):
It compiles fine and the built-in test suite (mostly) passes. 👍

However, I see a lot of warnings while running the test suite that I don't
remember seeing before. Some of them are VM related (they mention not yet
implemented features of the VM). But others seem to be unrelated afaict.
E.g.:

  libinterp\parse-tree\pt-tm-const.cc-tst ........................warning:
implicit conversion from numeric to char
warning: called from
    __test__ at line 2 column 1
    test    __run_test_suite__>run_test_dir at line 216 column 44
    __run_test_suite__>run_test_dir at line 180 column 40
    __run_test_suite__ at line 74 column 40
    D:/repo/Octave/octave-2/.build/../test/fntests.m at line 59 column 1

warning: implicit conversion from numeric to char
warning: called from
    __test__ at line 2 column 1
    test    __run_test_suite__>run_test_dir at line 216 column 44
    __run_test_suite__>run_test_dir at line 180 column 40
    __run_test_suite__ at line 74 column 40
    D:/repo/Octave/octave-2/.build/../test/fntests.m at line 59 column 1
[...]


Or:

  general\integral.m .............................................warning:
quadcc: Error tolerance not met.  Estimated error: 6.0494e-07
 pass   34/34
  general\integral2.m ............................................warning:
quadcc: Error tolerance not met.  Estimated error: inf
warning: quadcc: Error tolerance not met.  Estimated error: inf
warning: quadcc: Error tolerance not met.  Estimated error: inf
warning: quadcc: Error tolerance not met.  Estimated error: inf
 pass   50/50


The tests still pass though.

One actual test failure that seems to be new is also `warning` related:

>>>>> processing D:\repo\Octave\octave-2\test\struct.tst
***** error <invalid dot name structure assignment>
 c(4, 4, 4, 4).name  = "a";
 c(3, 3, 3, 3).value = 1;
 c([1, 3], 2, :, [3, 4]).value = 1;
!!!!! error failed.
Expected <invalid dot name structure assignment>, but got <invalid assignment
to cs-list outside multiple assignment>


Is handling Octave warnings affected by the VM?

I didn't look into the changes in any detail. Just a rather "nitty" remark: We
usually don't claim copyright for past years when new files are added.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10344>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/