[Octave-patch-tracker] [patch #10366] Same destructor order for octave_value:s in frame in std::vector for libstdc++ and libc++

[Petter T.]

URL:
  <https://savannah.gnu.org/patch/?10366>

                 Summary: Same destructor order for octave_value:s in frame in
std::vector for libstdc++ and libc++
                   Group: GNU Octave
               Submitter: petter
               Submitted: Sun 25 Jun 2023 12:18:46 AM UTC
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 25 Jun 2023 12:18:46 AM UTC By: Petter T. <petter>
"
Same destructor order for octave_value:s in frame in std::vector for libstdc++
and libc++

* libinterp/corefcn/stack-frame.cc:
        Explicitly overwrite octave_value:s in libstdc++ order for libc++ users
"

The current behaviour might be correct.

clang with libc++ Octave builds fails in the bytecode_cdef_use.m test due to
base_value_stack_frame using std::vector to store octave_value:s in the frame.
The test is dependent on that the tree_evaluator has the same classdef dtor
order as the VM.

The patch writes nil values to the std::vector:s for libc++ to get the same
dtor order as libstdc++.

I remember reading some documentation that classdef dtor order is not defined
for Octave so maybe the test should be updated to accept both orders instead?






    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Sun 25 Jun 2023 12:18:46 AM UTC  Name: octave_32274.patch  Size: 1KiB  
By: petter

<http://savannah.gnu.org/patch/download.php?file_id=54872>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10366>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/