octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10350] new function: isminphase.m


From: Leonardo
Subject: [Octave-patch-tracker] [patch #10350] new function: isminphase.m
Date: Wed, 28 Jun 2023 08:46:22 -0400 (EDT)

Follow-up Comment #2, patch #10350 (project octave):

Here are the corrections:

1) I've corrected the first line checking the input arguments:

 function flag = isminphase (b, a, tol)
-    if (nargin < 1 || nargin > 3 || (nargin == 2 && isrow (b)))
+    if (nargin < 1 || nargin > 3 || (nargin == 2 && ! isrow (b)) || (length
(a) > 1 && ! isrow (a)) || (length (b) > 1 && ! isrow (b)) || (nargin == 3 &&
! isscalar (tol)) )
        print_usage;
     endif

2) I've removed one test case that should not give an error:

 %!error n = isminphase ()
-%!error n = isminphase (1, 1, 1)
 %!error n = isminphase (1, 1, 1, 1)

The diff file and the corrected file follow attached.

(file #54889, file #54890)

    _______________________________________________________

Additional Item Attachment:

File name: isminphase.m                   Size:3 KB
    <https://file.savannah.gnu.org/file/isminphase.m?file_id=54889>

File name: diff_isminphase.m              Size:0 KB
    <https://file.savannah.gnu.org/file/diff_isminphase.m?file_id=54890>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10350>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]