[Octave-patch-tracker] [patch #10370] [MXE Octave] Launcher doesn't return Octave's exit code on Windows

[Markus Mützel]

Update of patch #10370 (project octave):

                  Status:                    None => Ready For Test         
                 Summary: Fix: Octave exit code does not work on Windows =>
[MXE Octave] Launcher doesn't return Octave's exit code on Windows

    _______________________________________________________

Follow-up Comment #2:

Thank you for this diff.

I cross-built Octave on Linux for Windows with this change. And the launcher
executable seems to return the exit code from the Octave process now. Tested
with `quit(10)` in Octave and `echo $?` at the prompt of the spawning bash.

I didn't notice any unexpected side effects from this change while testing on
Windows 11. So, I pushed the change with you as the author to the release
branch of MXE Octave here:
https://hg.octave.org/mxe-octave/rev/392c5255d044

It should be part of the next minor release of Octave for Windows.
Additionally, this change should be included in the nightly builds that can be
downloaded from here in a couple of days:
https://buildbot.octave.space/#/download

Marking as ready for test.

Btw: No big deal. But it would be better to track this kind of bug on the bug
tracker instead of the patch tracker. There are no definitive rules, but the
patch tracker is mostly for (larger) new features. The bug tracker is more
suitable for minor changes or bug fixes like this one.
(Additionally, the bug tracker sees a bit more traffic by maintainers. But I
eventually found your report here, too.)



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10370>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/