octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #10362] Fix problem with trivial ranges in


From: Petter T.
Subject: [Octave-patch-tracker] [patch #10362] Fix problem with trivial ranges in VM
Date: Mon, 17 Jul 2023 18:49:34 -0400 (EDT)

Follow-up Comment #4, patch #10362 (project octave):

Should I do another patch for making it octave_idx_type type instead of ints,
or add it to this bugfix?

The "trivial range" is used to speed up for-loops in the VM, cutting out a
check for "reversed" ranges as-well as not doing floating-point math.

With the posted patch there should be correct behavior, i.e. emulate the
ordinary double ranges but with integer math, for a subset of ranges that are
suitable. I overlooked actually checking if the base, increment etc are
integers in the original code.

The added benefit of using 'octave_idx_type' over int would be that integer
CPU operations are used for bigger ranges.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10362>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]