Re: [Octave-patch-tracker] [patch #9679] control package : additional frequency points to make bode and nyquist plots smoother

[octavecontrib]

The code is a significantly reworked version of what I had been using for my work (I switch between Matlab and Octave occasionally).

I have written the code. The original version I made for myself barely had any error checking since I deal with a very specific set of LTI systems. It didn't handle cell arrays of LTI systems either.

I tried to make it adhere to https://wiki.octave.org/Octave_style_guide for submitting the patch.

• If you can point out any points that need correction, I will modify the code and re attach.
• Are the deviations, related to visual attributes (spaces, indenting etc), or programming style (variable naming, usage of control structures, error checking and recovery, lack of commenting)?
• Where ever I have modified the original two functions in the __frequency_vector__ file, I have tried to copy the code in the same file and change the variable names (eg. calls to cellfun, arrayfun).
• Is there a place I could have posted this code for review before submitting the patch?

On Sun, Aug 19, 2018 at 5:00 PM Doug Stewart <INVALID.NOREPLY@gnu.org> wrote:

Follow-up Comment #4, patch #9679 (project octave):

I like what you have done. But it does not follow octave's codding standard.
Did you write this code, or copy it from somewhere?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9679>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/