[Pan-users] smtp sending problem

[Mark Derricutt]

Hiya,

The other day I posted about problems with 0.12.94 and forwarding posts via 
email.  No one seemed to reply to my posts.

Now, I don't know c++ (know the basics, I'm more delphi/java), and have 
been playing with ddd tonight, attached/below is a patch that allows pan to 
properly send posts via email.  However, I'm now noticing the occasional 
(quite regular) segfault/coredump of pan after the sending has compleated, 
not sure whats causing this thou, I'm still looking, but not sure what I'm 
looking for.

--- pan-0.12.94/pan/smtp.c      Mon Aug  5 11:50:53 2002
+++ pan-0.12.94-tal/pan/smtp.c  Thu Aug 15 21:26:26 2002
@@ -187,7 +187,7 @@
                const char * sender = g_mime_message_get_sender (message);
                InternetAddressList * list = internet_address_parse_string 
(sender);
                InternetAddress * ia = NULL;
-               if (list == NULL)
+               if (list != NULL)
                        ia = list->address;
                okay = ia!=NULL && ia->type==INTERNET_ADDRESS_NAME;
                if (okay)
@@ -259,13 +259,13 @@
                const char * line_start = NULL;

		while ((get_next_token_run (march, '\n', &march, &line_start, 
&line_len)))
-			okay = okay && !smtp_send_line_va (item, sock, "%*.*s", line_len, 
line_len, line_start);
+			okay = okay && !smtp_send_line_va (item, sock, "%*.*s\n", line_len, 
line_len, line_start);

                g_free (pch);
        }

        if (okay)
-               okay = !smtp_send_line (item, sock, ".\r\n");
+               okay = !smtp_send_line (item, sock, "\r\n.\r\n");
        if (okay)
                okay = pan_mute || smtp_get_response (item, sock, 250)==250;
        if (okay)






                                   -- \m/ --
 "...if I seem super human I have been misunderstood." (c) Dream Theater
        address@hidden - ICQ: 1934853 JID: address@hidden

smtp.patch
Description: Binary data