pan-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Pan-users] Problems downloading uuencoded binaries


From: Vadim Berezniker
Subject: Re: [Pan-users] Problems downloading uuencoded binaries
Date: Sun, 12 Jan 2003 14:11:09 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030107

Miguel Rubio wrote:
I made this change in util-mime.c :

*new util-mime.c*: static gboolean uu_is_ending_line (const char *
line) { return line!=NULL && !g_strncasecmp(line,"end",3) &&
!strstr(line,"cut") && !strstr(line,"CUT") &&
!g_strncasecmp(line,"fin",3); }

Shouldn't that be

return line!=NULL && ((!g_strncasecmp(line,"end",3) &&
!strstr(line,"cut") && !strstr(line,"CUT")) || !g_strncasecmp(line,"fin",3))

You were checking if the line was both 'end' and 'fin' ..

(Note: I don't know what the purpose of the 'CUT' check is so I don't know whether it belongs only to the check for 'end' or both. If it's both, it should be moved outside the parenthesis and the only two items connected by || would then be the check for 'end' and 'fin')





reply via email to

[Prev in Thread] Current Thread [Next in Thread]