Re: [Pan-users] Pan bug 712539 and 757672

[Rhialto]

On Tue 08 Mar 2016 at 18:54:48 +0100, Detlef Graef wrote:
> Yes, you are right. I was misleaded by the same name "clear" of the
> element function from deque and the function "clear" of the class
> FilterInfo which is invoked from the constructor.

It's a bit silly perhaps to call clear() from the constructor, but some
of the fields don't get default values and that's probably why the call
is made. When the call in the constructor is made, the deque is of
course already empty so nothing much happens in the loop.

> I've setup a build enviroment for Pan on FreeBSD 10.2 (AMD64) with clang.
> 
> I've tried to build the filterinfo branch, but as expected I get the
> error we know about:
[...]
> ./rules-info.h:34:9: note: definition of 'pan::RulesInfo' is not
> complete until the closing '}'
>   class RulesInfo
>         ^

In the new filterinfo2 branch I have now added changes that are supposed to
fix this.

Some remarks while I was looking at it:
- _negate seems unused in evaluating the rules in rules-filter.cc:
  test_article().
- but fortunately also set_type_le().
- AGGREGATE__AND seems to be handled incorrectly in test_article(): pass
  is always true.

Maybe that's because these RuleInfo objects are not used much yet and
it's simply not finished code.

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert  -- The Doctor: No, 'eureka' is Greek for
\X/ rhialto/at/xs4all.nl    -- 'this bath is too hot.'

signature.asc
Description: PGP signature