Re: [Paparazzi-devel] some drives

[Felix Ruess]

Hi Eduardo,

Thanks a lot Eduardo!

Can you please provide this as patches or even better via a pull request on github in the future?

Just dropping some files somewhere is rather cumbersome...

That would be great!

I committed (to v4.1) your ms5611 additions with some minor changes to not break existing configs:

* in the BARO_MS5611 message you want the actual measurement, not the baro_altitude

* made the MS5611_SLAVE_ADDR configurable from the airframe file didn't change the address

  -> why did you change it from 0xEC to 0xEE?

The bmp085 code is exactly the same as we already have in Paparazzi...

From a quick glance at imu_universal, it doesn't seem like a good idea to me.

Why should it be better to use a single subsystem/file to support all of these

and then enable specific bits in the code via more defines.

Instead of just making more readable/maintainable separate drivers for them?

Didn't check the rest... yet...

Separate patches/commits make it more clear which changes belong together and to what purpose.

Pull requests offer nice review/comment/discussion features.

Cheers, Felix

On Thu, Nov 15, 2012 at 5:31 PM, Eduardo lavratti <address@hidden> wrote:

Hello friends,

here are some drivers i am write / modified:
https://www.dropbox.com/sh/6ji6wpprh1kyctv/uv9nLxuju7

the drivers in this folder are:
ms5611 baro - working / tested
bmp085 baro - working / tested
imu_pololu (lsm303 + l3g4200) - working / tested
imu_universal - working / tested
  this driver work with: axl345 + lsm303 + itg3200 + l3d4200 + mpu6000 + hmc58xx
  option to use hmc5883 as mpu6000 slave - working

I created the imu_universal so i can use all my imu´s with this driver without need to write i new driver for every different imu.
i hope this help.

OBS: to use bmp085 and ms5611 as altimeter the file estimator.c need to be replaced.

the file eletrical.c solve the problem with overflow when using current sensor.

_______________________________________________
Paparazzi-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/paparazzi-devel