[Phpgroupware-users] Re: [Phpgroupware-developers] Dont update your CVS HEAD code

[Dan Kuykendall (Seek3r)]

I have actually gotten around to doing the commit.

Basicly all apps are broken, since none put their output in the proper 
location which is either done by
$GLOBALS['phpgw']->template->fp('phpgw_body','apps_tpl');

or even by dumping existing data into it the variable like this:

$GLOBALS['phpgw']->template->set_var('phpgw_body',$apps_output);


I have also only finished porting the default template set to the new 
rules. When I wake up I will start working on idsociety and verdilak, 
but for now I have forced all users into the default template set, just 
so that we can have a working reference point to use while we fix the apps.

Frames support is working very well. In fact if you are using frames 
(there is no preference setting for this yet, needs to be added), then 
it actually looks like its working. this is because the app output is 
happening before the stuff from the api, and with frames you dont notice 
so much.

I still have to do some cleanup of the phpgwapi/inc/functions.inc.php so 
that it is easier to read and the flow will make perfect sense to anyone 
learning how it all works.

I have also completely re-written the link() function we use. The new 
one flows better. I have done some inline documentation of what its 
doing, and its pretty easy to follow. Its also safer, since it doesnt 
allow duplicate get params, and will enforce SSL when configured to do so.

Im off to sleep, and will continue tomorrow.

I am looking forward to some code review by anyone that can. I want to 
make sure that these changes are truely for the believe they are.

Seek3r