pingus-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pingus-CVS] Issue 58 in pingus: Remove constructors for unique_ptr


From: pingus
Subject: [Pingus-CVS] Issue 58 in pingus: Remove constructors for unique_ptr
Date: Sat, 17 Sep 2011 02:33:16 +0000

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 58 by address@hidden: Remove constructors for unique_ptr
http://code.google.com/p/pingus/issues/detail?id=58

Under Debian testing, with GCC 4.6.1, revision a6815c61cbeca2ec5e35c3f006033e538982612a breaks.

Under that revision, the build fails with:
src/editor/object_selector.cpp: In constructor ‘Editor::ObjectSelector::ObjectSelector(Editor::EditorScreen*, const Rect&)’: src/editor/object_selector.cpp:512:12: error: call of overloaded ‘unique_ptr(int)’ is ambiguous

Calling the constructor of these unique_ptrs and passing 0 seems entirely unnecessary. Attached is a patch that simply removes the constructors. It also removes callback because it looks like it is entirely unused. This makes it compile fine on my machine, and looks safe to me.

Attachments:
        0001-Removes-the-constructors-of-unique_ptr-s-in-src-edit.patch  1.8 KB


reply via email to

[Prev in Thread] Current Thread [Next in Thread]