poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug(s) in parse_args and/or elsewhere


From: Jose E. Marchesi
Subject: Re: Bug(s) in parse_args and/or elsewhere
Date: Mon, 09 Dec 2019 23:40:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi John.

    in poke.c(parse_args) there is the code:
    
     case 's':
            case SCRIPT_ARG:
              {
                int ret = pk_cmd_exec_script (optarg);
                if (!ret)
                  goto exit_failure;
                poke_interactive_p = 0;
                break;
              }
    
    However pk_cmd_exec_script is written such that it returns zero on success.
    Hence poke exits with failure when it succeeds and exists with success when 
it fails.
    
    It seems there is a similar problem for the -c case.
    
I just pushed a fix for this.
Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]