[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add JSON Schema for Poke values.
From: |
Konstantinos Chasialis |
Subject: |
Re: [PATCH] Add JSON Schema for Poke values. |
Date: |
Wed, 8 Jul 2020 20:11:15 +0300 |
User-agent: |
SquirrelMail/1.4.23 [email.uoa.gr] |
> Hi Kostas,
>
> In etc/pk-mi-json-schema.json I see indentation mistakes in lines
> 32 98 196..197 209 247..250 255 259 270..281.
> Especially regarding arrays, it would be good to choose a certain
> indentation style, and stick to it.
>
> Also, in line 272: Why "anyOf"? Why not "oneOf"? What does a
> "PokeValue": {}
> mean?
>
> Bruno
>
>
Hello Bruno,
You are right about indentation style, but the problem was that I
copy-pasted the schema onto the email instead of attaching the patch file
and it messed up spaces.
You are also right about the schema, it should be oneOf.
Thank you.