poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] testsuite: Simplify poke.libpoke/values.c code using rea


From: Mohammad-Reza Nabipoor
Subject: Re: [PATCH 1/2] testsuite: Simplify poke.libpoke/values.c code using read_line
Date: Fri, 20 Nov 2020 22:46:53 +0330

Hi, Jose.

On Fri, Nov 20, 2020 at 06:58:25PM +0100, Jose E. Marchesi wrote:
> 
> Hi Mohammad.
> 
> > 2020-11-20  Mohammad-Reza Nabipoor  <m.nabipoor@yahoo.com>
> >
> >     * bootstrap.conf (gnu_modules): Add module `read-file`.
> >     * testsuite/poke.libpoke/values.c: Add includes: `assert.h`,
> >     `stdint.h`, `err.h`, `read-file.h`.
> >     (compile_initial_poke_code): Remove.
> >     (compile_poke_expressions): Likewise.
> >     (test_pk_val_equal_p): Refactored to use `asprintf` for string
> >     manipulation. Use memory buffers instead of `FILE`s.
> >     (test_pk_equal_file): Renamed to `testcase_pk_val_equal_p` with new
> >     interface to deal with memory buffers instead of `FILE`s.
> 
> This is OK for master, provided you use C-like comments like /* ..  */

Fixed and pushed (both patches).

Could you please add this check to `make check-syntax`?
I'm sure I'll use `//` again and again :(


Thanks


reply via email to

[Prev in Thread] Current Thread [Next in Thread]