poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] doc: fix code snippets and typos in manual


From: Guillermo Martinez
Subject: Re: [PATCH] doc: fix code snippets and typos in manual
Date: Thu, 30 Sep 2021 12:51:49 +0000

On Thursday, September 30, 2021 12:58:53 AM CDT Jose E. Marchesi wrote:

Hi Jose, 
> 
> Hi Guillermo.
> 
> > @@ -3541,7 +3541,7 @@ pixel occupies 3 bytes, so calculating@dots{}
> >  @example
> >  (poke) var ppl = byte @@ 3#b
> >  (poke) var lines = byte @@ 4#b
> > -(poke) save :from 0#b :size 5#b + ppl#b * lines#b :file "p.sbm"
> > +(poke) save :from 0#b :size (5 + ppl * 3 * lines)#b :file "p.sbm"
> 
> i would write that as:
> 
> 5#B + ppl#B * lines
hmm, I think that each pixel has 3 bytes and I think that this value is missing 
in
the above expression,

> 
> Other than that, OK for both master and maint/poke-1.
> Thanks!
> 
> PS: maint/poke-1 is the maintenance branch for poke 1.x.  What we
>     usually do for changes that are appropriate for both master (what
>     will become 2.x) and maint/poke-1 is to commit in master and then
>     cherry-pick (and amend if necessary) in maint/poke-1.
> 

Thanks!
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]