[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [COMMITTED] pkl: Fix error handling in SUB device
From: |
Jose E. Marchesi |
Subject: |
Re: [COMMITTED] pkl: Fix error handling in SUB device |
Date: |
Mon, 24 Jan 2022 16:08:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Mohammad.
OK for both master and maint/poke-2.
Thanks!
> 2022-01-24 Mohammad-Reza Nabipoor <mnabipoor@gnu.org>
>
> * libpoke/ios-dev-sub.c (ios_dev_sub_handler_normalize): Fix error
> reporting.
> ---
> ChangeLog | 5 +++++
> libpoke/ios-dev-sub.c | 5 ++++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 8b1a738a..4ad95d12 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2022-01-24 Mohammad-Reza Nabipoor <mnabipoor@gnu.org>
> +
> + * libpoke/ios-dev-sub.c (ios_dev_sub_handler_normalize): Fix error
> + reporting.
> +
> 2022-01-24 Jose E. Marchesi <jemarch@gnu.org>
>
> * poke/pk-table.pk: New field `indent'.
> diff --git a/libpoke/ios-dev-sub.c b/libpoke/ios-dev-sub.c
> index 0be2bf77..d7f7d5de 100644
> --- a/libpoke/ios-dev-sub.c
> +++ b/libpoke/ios-dev-sub.c
> @@ -59,7 +59,10 @@ ios_dev_sub_handler_normalize (const char *handler,
> uint64_t flags, int* error)
> {
> new_handler = strdup (handler);
> if (new_handler == NULL && error)
> - *error = IOD_ENOMEM;
> + {
> + *error = IOD_ENOMEM;
> + return NULL;
> + }
> }
>
> if (error)