poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pkl: Get rid of string literals as exception names


From: Luca Saiu
Subject: Re: [PATCH] pkl: Get rid of string literals as exception names
Date: Sun, 30 Jan 2022 12:46:21 +0100
User-agent: Gnus (Gnus v5.13), GNU Emacs 28.0.50, x86_64-pc-linux-gnu

Hello José and Mohammad.

On 2022-01-27 at 10:33 +0100, Jose E. Marchesi wrote:

> Related to this: I see these comments that Luca left when he first
> turned Jitter in poke to use non-threaded mode:
>
>   # XXX make non-relocatable: see raise

I do not remember.  The “XXX” style for comments is José's, but I may
well have followed for uniformity's sake after seeing other similar
comments.  In any case it has probably always been obsolete since every
instruction that seemed problematic was fixed; that seems more of a
"note to myself before I finish the change set".

> Luca, was it because of these string constants, or because the raising
> of the exceptions?  If the first, we can remove the comments once this
> patch gets applied.

Who knows now.  In any case I would remove it at this point.

-- 
Luca Saiu
* My personal web site:  http://ageinghacker.net
* GNU Jitter:            https://www.gnu.org/software/jitter
* GNU epsilon:           https://www.gnu.org/software/epsilon

I support everyone's freedom of mocking any opinion or belief, no
matter how deeply held, with open disrespect and the same unrelented
enthusiasm of a toddler who has just learned the word "poo".

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]