[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] pickles: add pickle for RISC-V RV32I instruction set
From: |
Jose E. Marchesi |
Subject: |
Re: [PATCH v2] pickles: add pickle for RISC-V RV32I instruction set |
Date: |
Sun, 18 Sep 2022 16:24:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> On Sun, Sep 18, 2022 at 10:23:35AM +0200, Jose E. Marchesi wrote:
>>
>> This is OK for master. I would push there and remove the copy in
>> pokology.
>>
>
> The problem with tests is that we need `riscv32-elf-as' and
> `riscv32-elf-objdump` to run the tests.
> That's the problem with using current tests.
Not an issue. You can add dejagnu (Tcl) machinery for that in
poke/testsuite/lib/whatever.exp and use it in testsuite/poke.pickles.
> I can put the verified .text sections in tests (using bin2poke), and
> use them as a verification. Without using the gas and objdump. I
> think that's enough for us in poke to catch regressions in
> poke.pickles/*
>
>
>> Also, please add yourself in hacking.org as the maintainer of this
>> pickle. You don't need approval to push updates to it.
>>
>
>
> OK.