Re: GNU poke 3.90.4 on AIX

[Jose E. Marchesi]

> On AIX 7.3.1, the build (with --disable-shared [since the shared libraries
> on AIX make me sick]) succeeds, but has warnings:
>
> ../../libpoke/libpoke.c:328:15: warning: implicit declaration of
> function 'asprintf'; did you mean 'vsprintf'?
> [-Wimplicit-function-declaration]
> ../../libpoke/pkl.c:792:9: warning: implicit declaration of function
> 'asprintf'; did you mean 'vsprintf'? [-Wimplicit-function-declaration]
> ../../libpoke/pkl-ast.c:3035:7: warning: implicit declaration of
> function 'asprintf'; did you mean 'vsprintf'?
> [-Wimplicit-function-declaration]
> ../../libpoke/pkl-env.c:218:15: warning: implicit declaration of
> function 'asprintf'; did you mean 'vsprintf'?
> [-Wimplicit-function-declaration]
> ../../libpoke/pkl-trans.c:1114:19: warning: implicit declaration of
> function 'asprintf'; did you mean 'vsprintf'?
> [-Wimplicit-function-declaration]
> pkl-tab.y:298:7: warning: implicit declaration of function 'asprintf';
> did you mean 'vsprintf'? [-Wimplicit-function-declaration]
> pkl-lex.l:178:3: warning: implicit declaration of function 'asprintf';
> did you mean 'vsprintf'? [-Wimplicit-function-declaration]
> ../../libpoke/pkl-diag.c:166:3: warning: implicit declaration of
> function 'vasprintf'; did you mean 'vsprintf'?
> [-Wimplicit-function-declaration]
> ../../libpoke/ios-dev.h:84:16: warning: implicit declaration of
> function 'asprintf'; did you mean 'vsprintf'?
> [-Wimplicit-function-declaration]
>
> The reason is that these two function (asprintf, vasprintf) are declared
> in gnulib-generated stdio.h files. Poke has 3 gnulib-generated stdio.h files:
>
>   gl/stdio.h                    does declare asprintf, vasprintf
>   gl-libpoke/stdio.h            does not
>   jitter/gnulib-local/stdio.h   does not
>
> But the files in libpoke/* include gl-libpoke/stdio.h, *not* gl/stdio.h,
> and thus they don't see the declarations.
>
> I've verified that the attached proposed patch fixes the warnings.
>
> Bruno
>
>>From 6f62e2fa39b2dd4ab3101300c71d07dabc58ebf1 Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Sun, 25 Feb 2024 19:21:22 +0100
> Subject: [PATCH] libpoke: Fix compiler warnings re [v]asprintf on AIX (regr.
>  2024-02-23).
>
> * bootstrap.conf (libpoke_modules): Add back 'vasprintf-posix'.
> ---
>  ChangeLog      | 5 +++++
>  bootstrap.conf | 3 ++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index aa3f1082..3fb803ca 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2024-02-25  Bruno Haible  <bruno@clisp.org>
> +
> +     libpoke: Fix compiler warnings re [v]asprintf on AIX (regr. 2024-02-23).
> +     * bootstrap.conf (libpoke_modules): Add back 'vasprintf-posix'.
> +
>  2024-02-25  Jose E. Marchesi  <jemarch@gnu.org>
>  
>       * NEWS: Update entry for 3.90.4.
> diff --git a/bootstrap.conf b/bootstrap.conf
> index 0924b412..0934ebf6 100644
> --- a/bootstrap.conf
> +++ b/bootstrap.conf
> @@ -1,6 +1,6 @@
>  # Bootstrap configuration.
>  
> -# Copyright (C) 2006-2023 Free Software Foundation, Inc.
> +# Copyright (C) 2006-2024 Free Software Foundation, Inc.
>  
>  # This program is free software: you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -111,6 +111,7 @@ libpoke_modules="
>    tempname
>    timespec
>    tmpdir
> +  vasprintf-posix
>    xalloc
>    strstr
>    lib-symbol-visibility

Hi Bruno.

This is OK for both master and maint/poke-4.

We will likely need to re-import vsnprintf-posix as well, and that will
hopefully fix the Solaris problems.

Thanks!