[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-332-g70c07

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.6.1-332-g70c074e
Date: Sat, 31 Jan 2009 05:06:56 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  70c074eb400ced7ee3ca4e01b701d6a30b75d174 (commit)
      from  000633bd0db563eaf5fa239c08dfcc7f241e7977 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 70c074eb400ced7ee3ca4e01b701d6a30b75d174
Author: Ben Pfaff <address@hidden>
Date:   Fri Jan 30 21:03:34 2009 -0800

    Accept LF, CR LF, and LF as new-line sequences in data files.
    Until now, PSPP has used the host operating system's idea of the
    new-line sequence when reading data files and other text files.
    This means that, when a file with CR LF line ends is read on an OS
    that uses LF as new-line (e.g. an MS-DOS file on Unix), each line
    appears to have a CR at the the end.  This commit fixes the
    problem, by normalizing the new-line sequence at time of reading.
    This commit eliminates a performance optimization from
    ds_read_line(), because the getdelim() function that it used cannot
    be made to stop reading at one of two different delimiters.  If
    this causes a real performance regression, then the getndelim2
    function from gnulib could be used to restore the optimization.
    Also adds a test to make sure that it works.
    Thanks to Rémi Dewitte <address@hidden> for pointing out the problem
    and providing an initial patch (which solved the problem in a
    completely different way from this commit).


Summary of changes:
 src/libpspp/str.c                                |   64 ++++++++++------------
 tests/                                |    1 +
 tests/command/{ =>} |   57 ++++++++++++--------
 3 files changed, 65 insertions(+), 57 deletions(-)
 copy tests/command/{ =>} (51%)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]