[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, value-rep, created. v0.6.1-636-g25

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, value-rep, created. v0.6.1-636-g251f3ff
Date: Tue, 02 Jun 2009 07:44:04 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, value-rep has been created
        at  251f3ff4c1a03f3acb116b3ab8c5c57df4eafbb6 (commit)

- Log -----------------------------------------------------------------
commit 251f3ff4c1a03f3acb116b3ab8c5c57df4eafbb6
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:51:45 2009 -0700

    argv-parser: Add assertion to find likely bugs in client code.

commit d4c4d452c7216f5b04140383dcb81a3211e2dfa6
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:51:19 2009 -0700

    datasheet: Fix bugs in datasheet_resize_column() found with new test.

commit 93d9385fede2d086cb666ce38451e8b3e7b899ff
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:46:24 2009 -0700

    datasheet-test: Add test for datasheet_resize_column().

commit 4c26f9b58180907ae2c40900a35091ddb4b340b4
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:43:33 2009 -0700

    datasheet-test: Fix printing of string values in error messages.

commit a66c47860b79f78f1d45938120370cb12b5563e9
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:26:13 2009 -0700

    datasheet-test: Check duplicate states before discarding them.
    By failing to check states whose hashes already appeared in the model
    checker table, the datasheet test was missing some bugs.  This commit
    changes the datasheet test code to check the state before it checks for
    the hash.

commit 55e86249d2d3c08382026d8bb621496c1e4a49ff
Author: Ben Pfaff <address@hidden>
Date:   Wed May 27 22:22:48 2009 -0700

    datasheet-test: Make column widths to test configurable on command line.

commit 8ef9411e517fe3fd6ad6ce71b409abf2a434b203
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:45:28 2009 -0700

    datasheet-test: Don't test null operations.
    By not testing null operations (such as inserting or deleting 0 rows or
    columns) the duration of the test is cut roughly in half, with little if
    any reduction in test coverage.

commit 84911feb1636cd21961eb6c7904d20be68e8d858
Author: Ben Pfaff <address@hidden>
Date:   Fri May 29 21:50:12 2009 -0700

    sparse-xarray-test: Style and comment fixes.

commit 08812cf2a7b9e9b972fb74553639c7b1a090a96b
Author: Ben Pfaff <address@hidden>
Date:   Tue May 26 23:04:32 2009 -0700

    value: New function value_swap.

commit 2c753de2d53c448ae2e836233af16e69073a1db5
Author: Ben Pfaff <address@hidden>
Date:   Tue May 26 22:02:48 2009 -0700

    Move datasheet test out of PSPP into a separate binary.
    When it's not difficult to do so, it is better to put tests in separate
    binaries instead of in the PSPP binaries, so that the binaries are not
    burdened with code that is not of real interest to users and to make the
    main PSPP binaries build faster.

commit 2d65d3d624b23a8a1ed698f7fd324dc956c8eee3
Author: Ben Pfaff <address@hidden>
Date:   Mon May 25 20:24:07 2009 -0700

    Make MAX_SHORT_STRING an implementation detail of the "value" code.
    MAX_SHORT_STRING used to be important.  It was referenced all over the
    source tree.  Now, there is little reason for code outside the "value"
    code itself to use it.

commit 219e11bdcbab13252577d04f7d198bc9bab3e58c
Author: Ben Pfaff <address@hidden>
Date:   Mon May 25 20:22:01 2009 -0700

    There is no good reason to have both of these constants, so replace all

commit 0908b5a8ebdd3c8f8d3ef1e926cc220a1c0d64a9
Author: Ben Pfaff <address@hidden>
Date:   Mon May 25 20:21:08 2009 -0700

    Fix portable file reader use of long strings.
    This code hadn't been converted to the new "union value" representation,
    where a single "union value" always represents a whole data item.  This
    commit fixes that.

commit 0dbcff34e06bd5569e31471b0c52502fbaee744b
Author: Ben Pfaff <address@hidden>
Date:   Mon May 25 20:20:07 2009 -0700

    Get rid of uses of MAX_SHORT_STRING in Gnumeric and PostgreSQL readers.
    MAX_SHORT_STRING is now intended to be an implementation detail of the
    value code.  There is no real reason that the Gnumeric or PostgreSQL
    readers need to use it, so make them use their own constants instead.

commit 3a51a0fc531d40a532df4f01462299e696d01159
Author: Ben Pfaff <address@hidden>
Date:   Mon May 25 20:07:19 2009 -0700

    Implement missing values for long string variables.

commit 050b95dd51e9671dac2484cb530d5ccebe5b9352
Author: Ben Pfaff <address@hidden>
Date:   Mon May 25 12:36:21 2009 -0700

    Fix test failure introduced along with parse_value().

commit 8e4fb73b39ce686958fa4f55ef4a914730abedde
Author: Ben Pfaff <address@hidden>
Date:   Sun May 24 19:36:01 2009 -0700

    sys-file-reader: Fix memory leak.

commit 5615b3f2d3de2433dab5e63107be30a45750e4aa
Author: Ben Pfaff <address@hidden>
Date:   Sun May 24 19:35:40 2009 -0700

    Add support for value labels on long string variables.

commit 21ea4558b0f581b5662f5e6fa5faf73417b22505
Author: Ben Pfaff <address@hidden>
Date:   Sun May 24 11:26:41 2009 -0700

    New function parse_value() for parsing a value of specified width.
    Occasionally a value of a given width needs to be parsed from syntax.
    This commit adds a helper function for doing so and modifies a few pieces
    of code to use it.  Probably there are other places where it would be
    useful that could not easily be found with "grep".
    This commit also renames the range-parser code to value-parser and puts
    the new function in there, as a natural generalization.
    Suggested by John Darrington.

commit c6c43bb50c5ee662b86ba74b0d3e3a58c09dd509
Author: Ben Pfaff <address@hidden>
Date:   Mon May 11 20:08:19 2009 -0700

    Make value_set_missing(), etc. tolerate values of width -1.
    In some circumstances a value of width -1 crops up, e.g. when a case is
    made from a dictionary that has had a variable deleted in the middle.
    Such a value has no content at all.  In the long run it should be possible
    to get rid of these values entirely--their presence is a wart--but for now
    the case and value code needs to tolerate them.
    This fixes a segfault in the GUI when inserting a new case when the
    datasheet case has a column with width -1 (due to deletion of a variable),
    which was caused by case_set_missing() calling value_set_missing() for
    the -1 width variable, which in turn was writing through an invalid

commit 766d768447de777a99a08ab064892676ada10a71
Author: John Darrington <address@hidden>
Date:   Tue May 12 07:18:31 2009 +0800

    Prevent invalid variable widths in variable sheet.

commit 2f50de43adb4cae3d6ac8f1ff2bb2328bc08ae03
Author: Ben Pfaff <address@hidden>
Date:   Mon May 11 06:33:35 2009 -0700

    Remove debug printfs that escaped from my local tree.

commit 2e181ed4d7e0fc0e5cbc40368f3eaa940ecb9a51
Author: Ben Pfaff <address@hidden>
Date:   Mon May 11 06:33:15 2009 -0700

    gui: Fix segfault when pushing Del on a long string variable cell.
    Thanks to John Darrington for reporting the problem.

commit ef69f7be809f9559e711c73e29eafa04a6ba7332
Author: Ben Pfaff <address@hidden>
Date:   Sun May 10 22:23:00 2009 -0700

    Change "union value" to dynamically allocate long strings.
    Until now, a single "union value" could hold a numeric value or a short
    string value.  A long string value (one longer than MAX_SHORT_STRING)
    required a number of contiguous "union value"s.  This situation was
    inconvenient sometimes, because any occasion where a long string value
    might be required (even if it was unlikely) required using dynamic
    memory allocation.
    With this change, a value of any type, regardless of whether it is numeric
    or short or long string, occupies a single "union value".  The internal
    representation of short and long strings is now different, however: long
    strings are now internally represented by a pointer to dynamically
    allocated memory.  This means that "union value"s must now be initialized
    and uninitialized properly, to ensure that memory is properly allocated
    and freed behind the scenese.
    This change thus has a ripple effect on PSPP code that works with values.
    In particular, code that deals with cases is greatly changed, because a
    case now needs to know the type of each value that it contains.  Thus, a
    new concept called a "case prototype", which represents the type and
    width of each value within a case, is introduced, and every place in PSPP
    that creates a case must now create a corresponding prototype to go with
    it.  This is why this commit is so big.
    As part of writing up this commit, it became clear that some code was poor
    enough that it needed to be rewritten entirely.  Therefore, CROSSTABS and
    T-TEST are almost completely modified by this commit.

commit f568a08ac6a4c5c8894728b6359c88af6f829510
Author: Ben Pfaff <address@hidden>
Date:   Wed May 6 22:58:01 2009 -0700

    output: Add auxiliary data parameter to tab_dim.
    Until now, the tab_dim function has not provided any way to pass auxiliary
    data to the table dimensioning function.  This commit adds this ability
    and updates all the callers of tab_dim to do so.

commit 653da53a0bb61120dadeca9898317a85d65c48df
Author: Ben Pfaff <address@hidden>
Date:   Wed May 6 22:47:51 2009 -0700

    New data structure sparse_xarray.

commit 037c20758c23e0bece995189aa44b901b935332e
Author: Ben Pfaff <address@hidden>
Date:   Wed May 6 20:34:14 2009 -0700

    New wrapper for access to temporary files.

commit 8b81a0ba7862d73f42e0255e998ac8640207c358
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:42:23 2009 -0700

    model-checker: Add command-line parser for model checking options.
    This adds a parser for command-line options to configure a set of
    mc_options for running the model checker.  It is used by an upcoming test
    for the sparse_xarray.  It might also make sense to break the datasheet
    tests out of PSPP into a separate program using this parser.

commit 0d5d2e32e690d0629e369b5dec84c568d0620779
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:39:03 2009 -0700

    Implement new command-line argument parser.
    glibc has two option parsers, but neither one of them feels quite
      - getopt_long is simple, but not modular, in that there is no
        easy way to make it accept multiple collections of options
        supported by different modules.
      - argp is more sophisticated and more complete, and hence more
        complex.  It still lacks one important feature for
        modularity: there is no straightforward way for option groups
        that are implemented independently to have separate auxiliary
    The parser implemented in this commit is meant to be simple and
    modular.  It is based internally on getopt_long.
    The initial use for this option parser is for an upcoming commit of a test
    program that has some of its own options and some from the model checker,
    but it should also be appropriate for PSPP and PSPPIRE if anyone wants to
    adapt them to use it.

commit f7768caf9f426d8ff5fd157aca0f053c1257aa56
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:30:02 2009 -0700

    model-checker: Don't discard error states.
    Even if a state with an error is a duplicate, we don't want to discard it,
    because then we lose information about bugs.

commit b81c023ef78511a2aed4ac28e8f0546efca3c403
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:27:05 2009 -0700

    model-checker: Revise advice on checking for duplicates.
    Until now the documentation on the model checker has advised checking for
    a duplicate state before checking for consistency, but in fact this can
    cause bugs to be missed if only some paths to a given state yield
    incorrect results.  So revise the advice to check for consistency before
    checking for a duplicate state.

commit 32d7529bc9552fce15e4f01b2a0be91518e1645a
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:20:42 2009 -0700

    model-checker: Add more progress functions.
    The model checker supports "progress functions" that report the current
    status of the model checking run.  Until now the implementation only
    exported a single progress function that printed a line of dots across
    stderr.  This commit moves the "fancy" progress function that was
    previously part of the PSPP language code into the model checker itself
    and adds an even more verbose progress function as well.

commit a887de785bcd3a17082083f1a3461e6a0baa84cd
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 22:33:48 2009 -0700

    model-checker: Move summary printing function into model checker.
    There is no reason that the model checker itself should not be able to
    print a summary of its results.  Until now, this code was buried in the
    PSPP language code, but the model checker itself is a better place for it.

commit e91e43790bb695bbb4dba12b471fb9caa79e7ed3
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 21:09:12 2009 -0700

    model-checker: Kill dependencies and move back to libpspp.
    Commit 95b074ff3 "Moved the datasheet testing code out of
    src/{libspp,data}" moved the model-checker implementation from libpspp
    into language/tests because it depended on math/moments.h and
    data/val-type.h, which violates the dependency structure of the PSPP
    However, now I want to use the model checker in a test that should not
    need to use anything from language/tests, so this commit eliminates these
    dependencies and moves the model checker back to src/libpspp.

commit f9b087ed49271589dade8549bf28100855502708
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 21:53:07 2009 -0700

    sparse-array: Simplify code slightly.
    Instead of checking whether the key is in range in each caller of
    find_leaf_node, do it in find_leaf_node itself.  This also allows checking
    the cache before checking whether the key is in range, which might be an

commit 6b202c0917136f81fd40d155904fad87d20c4b30
Author: Ben Pfaff <address@hidden>
Date:   Wed May 6 20:22:09 2009 -0700

    sparse-array: Improve iteration interface.
    The sparse_array_scan function only supports iteration in the forward
    direction and its interface is somewhat awkward.  This commit replaces it
    by four new functions that allow iteration in both forward and reverse
    directions and have a more conventional interface.

commit 762217784d1e65f768c50ac6ebe9a44b51f62dd0
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:51:54 2009 -0700

    sparse-array: Use __builtin_ctzl on GCC 4.0 or later, as an optimization.
    This should be a worthwhile optimization in many cases, because
    __builtin_ctzl compiles to a single machine instruction on x86, whereas
    the generic implementation compiles to several.

commit 9e6cd664864de9d9bb84f07e506e4170bfce2bc5
Author: Ben Pfaff <address@hidden>
Date:   Mon May 4 19:31:16 2009 -0700

    range-set: New functions range_set_last and range_set_prev.
    These are useful for iterating through a range set in reverse order.

commit 931e673fd6697a0ba1fe3568031f682a575de1d9
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:27:54 2009 -0700

    range-set: Add new function range_set_scan().

commit f592e1928b3b9837b3354df335d1b309dc0d2bd7
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:27:10 2009 -0700

    range-set: Inline some simple functions.
    Some of the range-set functions are very simple and worth inlining, so
    move the definitions of those functions into range-set.h.  This required
    moving the definition of struct range_set and struct range_set_node into
    the header.  Some of the functions used internally by those functions had
    to be moved too, and renamed as well since for internal use in range-set.c
    their names did not respect the namespace.

commit d925b7673892961eeb721ab01ffda97cfb21e7df
Author: Ben Pfaff <address@hidden>
Date:   Thu Apr 23 20:14:52 2009 -0700

    range-set: Add test coverage for range_set_destroy(NULL).
    "gcov -b" showed that range_set_destroy() was never called with a NULL
    argument.  There's no reason not to test that too (although of course it
    is unlikely to be broken).

commit acb5c0b50aa128b39aa2e6a511994ad042e3c412
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 07:03:24 2009 -0700

    range-set: New function range_set_allocate_fully.

commit 28a76e61cdd93275a1eb48ba5956cad71ee35c99
Author: Ben Pfaff <address@hidden>
Date:   Tue Mar 31 22:00:44 2009 -0700

    Delete CORRELATIONS skeletal parser.
    This code didn't do anything useful, it just parsed syntax.  We can
    resurrect it when someone wants to implement CORRELATIONS later.

commit 23cbe1687b3ab1e069635635ffbfbf22ee289552
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 07:03:02 2009 -0700

    pool: New function pool_strdup0.
    This function is the pool analogue of xmemdup0, except that it is only
    appropriate for use with strings.

commit b2024810c6bcd94c8dd929b0e2bf8b862874f747
Author: Ben Pfaff <address@hidden>
Date:   Tue May 5 05:46:01 2009 -0700

    datasheet: Drop false dependency on md4.h.
    datasheet-check.c doesn't use anything from md4.h, so there's no point in
    including it.

commit 5a2351f985bc084a3484c6f518821f8365d76074
Author: Ben Pfaff <address@hidden>
Date:   Wed Apr 15 22:31:56 2009 -0700

    perl-module: Better document "make test" requirements.

commit 5e459a46ad567ca2a84b2d60928192264000e995
Author: Ben Pfaff <address@hidden>
Date:   Thu Jan 15 20:39:18 2009 -0800

    t-test: Move 'mode' variable from file scope into cmd_t_test().

commit 85a5a2c2ec643256f67aca6b8f4ed3ae906cb6aa
Author: Ben Pfaff <address@hidden>
Date:   Thu Jan 15 20:37:32 2009 -0800

    t-test: Move 'cmd' variable from file scope into cmd_t_test().
    This variable was only used inside cmd_t_test() anyhow.

commit 0eddd95ce06749a614710c9282bbd20400a9239e
Author: Ben Pfaff <address@hidden>
Date:   Thu Jan 15 20:34:43 2009 -0800

    t-test: Remove write-only variable.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]