[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, stable, updated. v0.6.1-25-g0faad2

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, stable, updated. v0.6.1-25-g0faad29
Date: Fri, 19 Jun 2009 03:17:52 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, stable has been updated
       via  0faad29b5c735cce9672331681392c2b1f0b5690 (commit)
       via  399bf939cf7597e9dbe1810a07ffcb5c2ed57d32 (commit)
      from  e591f2e6af157c2573e988ae4f5c5eb8027282fb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0faad29b5c735cce9672331681392c2b1f0b5690
Author: Ben Pfaff <address@hidden>
Date:   Wed Jun 17 21:24:38 2009 -0700

    sys-file-reader: Don't warn if compression bias field is 0.
    Some software writes a value of 0 to the compression bias field.  We
    expect that this field has a value of 100 and warn if we see any other
    value, but there is no real need to do so (because it is very likely
    that we can read the file correctly in any case).  So suppress the
    warning if we see a value of 0 here, because it bothers users.
    Thanks to Tony Reardon <address@hidden> for reporting this
    unnecessary warning.

commit 399bf939cf7597e9dbe1810a07ffcb5c2ed57d32
Author: Ben Pfaff <address@hidden>
Date:   Wed Jun 17 21:11:10 2009 -0700

    por-file-reader: Tolerate short lines when detecting portable files.
    When the portable file reader reads a file, it assumes that a line
    shorter than 80 bytes should actually be padded out on the right with
    spaces, because this is a fairly common problem in practice, perhaps
    due to text editors or other software that drops spaces at the end of
    a line.
    However, pfm_detect, the function that is supposed to detect whether
    a given file is an SPSS portable file, did not apply this heuristic to
    the data that it read at the beginning of the file, and thus files in
    which the first few lines were truncated this way were not detected
    properly as portable files.
    This commit fixes the problem by making pfm_detect a little bit
    smarter.  It would probably be better to actually unify the
    file-reading logic, instead of implementing it in two separate places,
    but this appears to work adequately too.
    Thanks to Tony Reardon <address@hidden> for reporting the problem
    and supplying a file that demonstrated it.


Summary of changes:
 src/data/por-file-reader.c |   21 +++++++++++++++++----
 src/data/sys-file-reader.c |   18 +++++++++++++++---
 2 files changed, 32 insertions(+), 7 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]